analyze() is running slow

[quali74]

Hi

Does anybody know why the analyze() function could run slowly? My video files are 70 MB large and it takes a very long time for the GetID3 to extract the width and height.

Thanks

[Pernod]

What do you call a very long time? The size of the file shouldn't be relevant as GetID3 is only looking at the file header in most cases. What is the file format of the videos (avi, mkv, etc.)?

[quali74]

The video format is FLV. It takes about 30 seconds.
With another video which is WMV, it runs fine and very fast.

I only need the width and height. Is there a way I analyze() could only return those values?

[Pernod]

From looking at the code, GetID3 is actually seeking for header data throughout the entire file, whereas it should actually only seek through the actual header. This would explain the time taken.

This should be reported as a bug.

[franki]

read this: viewtopic.php?f=3&t=886

The link I posted could be useful.

[Pernod]

I now see that the reason for seeking throughout the whole file is to determine the duration, but the duration is also available in the metadata so there is no need to do this.

I'm also seeing incorrect audio details being returned so it could take a little while to figure this out.

[quali74]

hi

that is correct. I also get errors regarding the audio used in the FLV.

Notice Undefined offset: 3 in getid3\module.audio-video.flv.php 234

[Pernod]

I have made the following changes to the flv module:
- Added details of missing audio/video codecs.
- Fixed parsing of audio tag.
- playtime_seconds is now set to duration from onMetaData. If the duration metadata does not exist then the whole file will be parsed.

All details returned have been verified against MediaInfo.

Hope James can include this with the next release.

[James Heinrich]

Good work, thanks. I've reviewed the changes and will include them in the next release (including v2.x)

[edit]attachments replaced with newer ones in later post[/edit]

[Pernod]

Thanks, was hoping for some feedback from the OP but seems to have disappeared.

[James Heinrich]

Now v0.6 is even better with better support for h264, thanks Evgeny Moysevich.