Patch for mysql cache in 1.9.1

[carlocapocasa]

Hi James!

Thanks a log for making getID3. I am the author of Audiobar, a WordPress plugin, and I just switched to using getID3 in the 1.0.1 release (out since yesterday, yay). My previous tag libs were pretty flaky, but yours performed fantastic in all my tests and I love the architecture. Kudos!

So I hacked the mysql caching extension a little:

• Empty string returned on cache miss, fixed
• PHP 5.2+ chokes on $this::$staticvar, changed to self::$staticvar
• Optionally provide your own cache table name on init

To apply the changes, do

Code: Select all

patch < mysql-mod.patch

in getid3 dir of 1.9.1

Hope this is useful!

Carlo

[James Heinrich]

I'd be interested in seeing your changes. Did you mean to attach the patch file? Or where can I see it?

[carlocapocasa]

Oh sorry missed an upload err msg, here it is! Carlo

[James Heinrich]

Thanks, changes accepted mostly as provided, will be included in v1.9.2

[carlocapocasa]

Great! *is proud*

Good point btw that someone might provide a non-hardcoded table name... Paranoia is a quality I truly admire :)