bug in module.audio-video.quicktime.php

Think you found a bug in getID3()? Post here with details.
Post Reply
Evgeny Moysevich
User
Posts: 6
Joined: Tue May 26, 2009 2:01 pm
Are you a spambot?: no

bug in module.audio-video.quicktime.php

Post by Evgeny Moysevich » Mon Nov 03, 2014 8:43 pm

There is a bug in module.audio-video.quicktime.php, it shows itself when memory_limit is disabled ($this->getid3->memory_limit < 0). In this case negative number of bytes is passed to the fread function. I added a check for the $this->getid3->memory_limit in two places in module.audio-video.quicktime.php and now it works for me. I attached modified file, but my IDE reformatted the code, so if you will check the diffs, you will see a lot of them.
Attachments
module.audio-video.quicktime.php
(117.12 KiB) Downloaded 934 times

James Heinrich
getID3() v1 developer
Posts: 1435
Joined: Fri May 04, 2001 4:00 pm
Are you a spambot?: no
Location: Northern Ontario, Canada
Contact:

Re: bug in module.audio-video.quicktime.php

Post by James Heinrich » Tue Nov 04, 2014 4:51 pm

I'm not sure which version you've modified. Could you please, for clarity, supply your patch against the current version of module.audio-video.quicktime.php since there seems to be more differences than what you describe (and not just IDE reformatting).

Evgeny Moysevich
User
Posts: 6
Joined: Tue May 26, 2009 2:01 pm
Are you a spambot?: no

Re: bug in module.audio-video.quicktime.php

Post by Evgeny Moysevich » Wed Nov 05, 2014 4:03 pm

I modified version 1.9.8-20140511. I checked the current version and it seems that issue with memory_limit is already fixed there.

James Heinrich
getID3() v1 developer
Posts: 1435
Joined: Fri May 04, 2001 4:00 pm
Are you a spambot?: no
Location: Northern Ontario, Canada
Contact:

Re: bug in module.audio-video.quicktime.php

Post by James Heinrich » Wed Nov 05, 2014 4:12 pm


Post Reply