[1.9.0] Pictures in Quicktime

Locked
Pernod
getID3() contributor
Posts:103
Joined:Sat Mar 21, 2009 5:30 pm
Are you a spambot?:no
Location:London, UK
Contact:
[1.9.0] Pictures in Quicktime

Post by Pernod » Sat Jul 09, 2011 11:52 am

Since the recent changes to picture handling in 1.9.0 I am no longer seeing the covr atom being returning from M4A files. PM me if you need a test file.

Pernod
getID3() contributor
Posts:103
Joined:Sat Mar 21, 2009 5:30 pm
Are you a spambot?:no
Location:London, UK
Contact:

Re: [1.9.0] Pictures in Quicktime

Post by Pernod » Sat Jul 09, 2011 3:54 pm

Initial investigation reveals that all my tags are in the udta -> meta subatoms. Subatoms of meta are not being parsed.

Pernod
getID3() contributor
Posts:103
Joined:Sat Mar 21, 2009 5:30 pm
Are you a spambot?:no
Location:London, UK
Contact:

Re: [1.9.0] Pictures in Quicktime

Post by Pernod » Sat Jul 09, 2011 4:21 pm

The meta atom should be parsed as follows:

Old:

Code: Select all

case 'meta': // METAdata atom
				$atom_structure['subatoms']  = $this->QuicktimeParseContainerAtom($atom_data, $baseoffset + 8, $atomHierarchy, $ParseAllPossibleAtoms);
				break;
Fixed:

Code: Select all

case 'meta': // METAdata atom
				$atom_structure['version']   = getid3_lib::BigEndian2Int(substr($atom_data,  0, 1));
            $atom_structure['flags_raw'] = getid3_lib::BigEndian2Int(substr($atom_data,  1, 3));
            $atom_structure['subatoms']  = $this->QuicktimeParseContainerAtom(substr($atom_data, 4), $baseoffset + 8, $atomHierarchy, $ParseAllPossibleAtoms);
				break;

Pernod
getID3() contributor
Posts:103
Joined:Sat Mar 21, 2009 5:30 pm
Are you a spambot?:no
Location:London, UK
Contact:

Re: [1.9.0] Pictures in Quicktime

Post by Pernod » Sat Jul 09, 2011 4:56 pm

The artwork is still being set in ["tags"]["quicktime"]["artwork"] and not in ["comments"]["picture"].

James Heinrich
getID3() v1 developer
Posts:1477
Joined:Fri May 04, 2001 4:00 pm
Are you a spambot?:no
Location:Northern Ontario, Canada
Contact:

Re: [1.9.0] Pictures in Quicktime

Post by James Heinrich » Sun Jul 10, 2011 8:26 pm

Please send me a test file.

Pernod
getID3() contributor
Posts:103
Joined:Sat Mar 21, 2009 5:30 pm
Are you a spambot?:no
Location:London, UK
Contact:

Re: [1.9.0] Pictures in Quicktime

Post by Pernod » Mon Jul 11, 2011 12:33 pm

Did you get the test file for this?

James Heinrich
getID3() v1 developer
Posts:1477
Joined:Fri May 04, 2001 4:00 pm
Are you a spambot?:no
Location:Northern Ontario, Canada
Contact:

Re: [1.9.0] Pictures in Quicktime

Post by James Heinrich » Mon Jul 11, 2011 1:10 pm

I did grab it from your site (if you emailed them, I never got the email, but it doesn't matter). I have not yet examined the issue, but I will.

James Heinrich
getID3() v1 developer
Posts:1477
Joined:Fri May 04, 2001 4:00 pm
Are you a spambot?:no
Location:Northern Ontario, Canada
Contact:

Re: [1.9.0] Pictures in Quicktime

Post by James Heinrich » Sun Jul 17, 2011 9:15 pm

Pernod wrote:The meta atom should be parsed as follows:
I agree (thanks for supplying the code :)

Cover art is now copied to [comments][picture] in the standard fashion (into a subarray with [data] and [image_mime] set).

Attached fix will be included in v1.9.1
Attachments
module.audio-video.quicktime.php
(106.17KiB)Downloaded 791 times

Pernod
getID3() contributor
Posts:103
Joined:Sat Mar 21, 2009 5:30 pm
Are you a spambot?:no
Location:London, UK
Contact:

Re: [1.9.0] Pictures in Quicktime

Post by Pernod » Mon Jul 18, 2011 7:57 pm

Thanks, issue closed.

Locked