replay_gain tags

Locked
lieven
User
Posts:8
Joined:Thu Mar 17, 2011 9:37 pm
Are you a spambot?:no
replay_gain tags

Post by lieven » Tue Sep 20, 2011 9:55 pm

I'm having problems to fetch the replay_gain tags.
mostly using audio files (mp3, wma)

The mp3's are tagged using media monkey.
In mediamonkey I'm seeing the replay gain tags.
And in Mp3tag i'm also seeing the replay gain tags.

In getid3 i don't get the replay gain tags.
The replay gain tags just say "volume : 89"

I've included screenshots from Mp3tag, mediamonkey and a screenshot from the output of getid3.
Mp3tag.gif
Mp3tag.gif (26.25KiB)Viewed 11146 times
mediamonkey.gif
mediamonkey.gif (13.54KiB)Viewed 11146 times
getid3.gif
getid3.gif (55.31KiB)Viewed 11146 times
I'm using the latest version "GETID3_VERSION 1.9.1-20110810"

Any help appreciated

James Heinrich
getID3() v1 developer
Posts:1477
Joined:Fri May 04, 2001 4:00 pm
Are you a spambot?:no
Location:Northern Ontario, Canada
Contact:

Re: replay_gain tags

Post by James Heinrich » Tue Sep 20, 2011 10:54 pm

If you could PM me a link to a sample file I'll take a look.

lieven
User
Posts:8
Joined:Thu Mar 17, 2011 9:37 pm
Are you a spambot?:no

Re: replay_gain tags

Post by lieven » Wed Sep 21, 2011 11:55 am


James Heinrich
getID3() v1 developer
Posts:1477
Joined:Fri May 04, 2001 4:00 pm
Are you a spambot?:no
Location:Northern Ontario, Canada
Contact:

Re: replay_gain tags

Post by James Heinrich » Wed Sep 21, 2011 3:14 pm

It seems that MediaMonkey is including the standard RGAD (ReplayGainADjustment) frame with null data (zero adjustment), and then stuffing their adjustment values into a generic "user-specified text" field, with appropriate descriptors ("replaygain_track_gain", "replaygain_track_peak", etc).

I'll see if I can tweak something in getID3 to correctly handle this, while not ignoring valid RGAD data. Stay tuned.

James Heinrich
getID3() v1 developer
Posts:1477
Joined:Fri May 04, 2001 4:00 pm
Are you a spambot?:no
Location:Northern Ontario, Canada
Contact:

Re: replay_gain tags

Post by James Heinrich » Wed Sep 21, 2011 4:17 pm

I've patched module.tag.id3v2.php to handle this situation. Please let me know if you find any other files where the attached version doesn't correctly handle the replay-gain data.
1252.png
1252.png (15.75KiB)Viewed 11135 times
Patched version will be included in getID3 v1.9.2
Attachments
module.tag.id3v2.php
(127.49KiB)Downloaded 872 times

lieven
User
Posts:8
Joined:Thu Mar 17, 2011 9:37 pm
Are you a spambot?:no

Re: replay_gain tags

Post by lieven » Wed Sep 21, 2011 6:22 pm

I've tested with a couple of music files and it works.

Remark:
I've noticed that the ID3v2 TXXX tags are filled with the correct values.
Also the replay_gain array is filled correctly.
Only the ID3v2 RGAD tags are still empty...
Not much of an issue for me, because i was going to use the replay_gain array, but just to mention...


Thanks, great work.

James Heinrich
getID3() v1 developer
Posts:1477
Joined:Fri May 04, 2001 4:00 pm
Are you a spambot?:no
Location:Northern Ontario, Canada
Contact:

Re: replay_gain tags

Post by James Heinrich » Wed Sep 21, 2011 6:36 pm

The RGAD tag is empty [in getID3 returned data] because the RGAD tag is empty [in the actual file] because MediaMonkey made it empty.

getID3 tries to report the data as-is, but also provide a parsed copy in a more-useful format in a central place, consistent across formats. So reply-gain info should always be extracted from [replay_gain] (since it may come from ID3v2.RGAD, ID3v2.TXXX, APE, etc) but will always be parsed and stored in the same location no matter what format you're looking at.

lieven
User
Posts:8
Joined:Thu Mar 17, 2011 9:37 pm
Are you a spambot?:no

Re: replay_gain tags

Post by lieven » Wed Sep 21, 2011 9:09 pm

ah, i see,
I'll be using the info from [replay_gain] then.

Locked