ID3v1 genre name typo

Locked
literal
User
Posts:3
Joined:Fri Dec 09, 2011 11:27 pm
Are you a spambot?:no
ID3v1 genre name typo

Post by literal » Fri Dec 09, 2011 11:45 pm

module.tag.id3v1.php:

static function getid3_id3v1::ArrayOfGenres()
[...]
static $GenreLookup = array(
[...]
144 => 'Trash Metal',
[...]

That should be "Thrash Metal", not "Trash Metal". Look it up, e. g. here: http://en.wikipedia.org/wiki/Thrash_metal or here: http://www.urbandictionary.com/define.p ... sh%20metal :-) Or check any of the lists of WinAMP ID3v1 genre extensions...

James Heinrich
getID3() v1 developer
Posts:1477
Joined:Fri May 04, 2001 4:00 pm
Are you a spambot?:no
Location:Northern Ontario, Canada
Contact:

Re: ID3v1 genre name typo

Post by James Heinrich » Sat Dec 10, 2011 12:04 am

literal wrote:That should be "Thrash Metal", not "Trash Metal"
Wow... I can't believe how long that bug has been there with nobody noticing. It's been that way since the "extended" ID3v1 genre list was added in v1.2.0:

Code: Select all

// Version History:
//   1.20:	[January-15-2001]
...
//          ID3v1 genres 126 through 147
Fixed for v1.9.3

literal
User
Posts:3
Joined:Fri Dec 09, 2011 11:27 pm
Are you a spambot?:no

Re: ID3v1 genre name typo

Post by literal » Sat Dec 10, 2011 12:34 am

Wow... I can't believe how long that bug has been there with nobody noticing. It's been that way since the "extended" ID3v1 genre list was added in v1.2.0:
:-)

And thanks for the quick fix!

Locked