[2.0.0-b4] ID3v2 last symbol missing (patch attached)

Locked
webta
User
Posts:2
Joined:Tue Mar 13, 2007 3:30 pm
[2.0.0-b4] ID3v2 last symbol missing (patch attached)

Post by webta » Tue Mar 13, 2007 3:33 pm

--- module.tag.id3v2.php_orig Tue Mar 13 17:28:17 2007
+++ module.tag.id3v2.php Tue Mar 13 17:27:54 2007
@@ -630,7 +630,7 @@

// remove possible terminating \x00 (put by encoding id or software bug)
$string = $getid3->iconv($parsed_frame['encoding'], 'UTF-8', $parsed_frame['data']);
- if ($string[strlen($string)-1] = "\x00") {
+ if ($string[strlen($string)-1] == "\x00") {
$string = substr($string, 0, strlen($string)-1);
}
$getid3->info['id3v2']['comments'][$parsed_frame['framenameshort']][] = $string;


Radio Hosting

alexpw
User
Posts:3
Joined:Mon Nov 03, 2008 4:58 am

Re: [2.0.0-b4] ID3v2 last symbol missing (patch attached)

Post by alexpw » Mon Nov 03, 2008 5:06 am

Thank you for the patch!

For those with little experience with reading the output of diff or merging the patch through the command line.

@ Line 630
Correct the condition in the if statement by changing "=" to "==" and the line will then read:

Code: Select all

if ($string[strlen($string)-1] == "\x00") {

nnhubbard
User
Posts:22
Joined:Fri Dec 19, 2008 5:20 am

Re: [2.0.0-b4] ID3v2 last symbol missing (patch attached)

Post by nnhubbard » Tue Dec 23, 2008 2:34 am

Is this going to be added to an actual download? We need to have users download getID3, but having them add a patch is kind of a pain!

James Heinrich
getID3() v1 developer
Posts:1477
Joined:Fri May 04, 2001 4:00 pm
Are you a spambot?:no
Location:Northern Ontario, Canada
Contact:

Re: [2.0.0-b4] ID3v2 last symbol missing (patch attached)

Post by James Heinrich » Sun Mar 08, 2009 3:14 pm

Patch will be included in v2.0.0b5

Locked