1.9.3 demo.write.php not writing tags

Post Reply
Majere
User
Posts: 1
Joined: Wed Aug 01, 2012 1:22 am
Are you a spambot?: no

1.9.3 demo.write.php not writing tags

Post by Majere » Wed Aug 01, 2012 1:26 am

Hi everybody,
as you can see @ http://domain.name.removed/radio/files/ ... browse.php
Getid3() v 1.9.3 is working fine on my host but it seems it cannot edit my mp3 file's tags.
Infact demo.write.php always stops at "starting to write tag(s)"..

Same malfunction on my local host.. please help.

beardedgeek
User
Posts: 1
Joined: Tue Sep 11, 2012 9:40 pm
Are you a spambot?: no

Re: 1.9.3 demo.write.php not writing tags

Post by beardedgeek » Tue Sep 11, 2012 9:46 pm

I had this issue too

Found an error within the apache logs that pointed me towards this line:

$tagwriter->overwrite_tags = false;

Commented it out, and it now works. Setting it to true also works.

The error I found in apache's log is:

Code: Select all

[Tue Sep 11 17:32:36 2012] [error] [client 90.204.200.218] PHP Fatal error:  Uncaught exception 'Exception' with message '$this->overwrite_tags=false is known to be buggy in this version of getID3. Will be fixed in the near future, check www.getid3.org for a newer version.' in /var/www/html/getid3/write.php:422\nStack trace:\n#0 /var/www/html/getid3/write.php(564): getid3_writetags->MergeExistingTagData('id3v2', Array)\n#1 /var/www/html/getid3/write.php(284): getid3_writetags->FormatDataForID3v2(3)\n#2 /var/www/html/demos/demo.simple.write.php(50): getid3_writetags->WriteTags()\n#3 {main}\n  thrown in /var/www/html/getid3/write.php on line 422
Centos 5.5, PHP 5.3

ebwallibabwoule
User
Posts: 1
Joined: Mon Feb 17, 2014 10:33 pm
Are you a spambot?: no

Re: 1.9.3 demo.write.php not writing tags

Post by ebwallibabwoule » Mon Feb 17, 2014 10:52 pm

I had the same problem in 1.9.7. beardedgeek is right. Replacing $this->overwrite_tags by true on line 419 solved the writing problem for me.

Code: Select all

public function MergeExistingTagData($TagFormat, &$tag_data) {
    // Merge supplied data with existing data, if requested
    if (true) { //<------------------was $this->overwrite_tags
        // do nothing - ignore previous data
    } else {
throw new Exception('$this->overwrite_tags=false is known to be buggy in this version of getID3. Will be fixed in the near future, check www.getid3.org for a newer version.');
//...
    }
//...
}

Post Reply