Parse DisplayUnit and PixelCrop*

Locked
jan
User
Posts: 1
Joined: Tue Nov 27, 2012 11:07 pm
Are you a spambot?: no

Parse DisplayUnit and PixelCrop*

Post by jan » Tue Nov 27, 2012 11:11 pm

attached patch parses PixelCrop* and DisplayUnit and puts it into track_info. its against getid3-1.9.4b1-20121005.zip
Attachments
parse_DisplayUnit_and_PixelCropFoo.patch.txt
(1.72 KiB) Downloaded 431 times

James Heinrich
getID3() v1 developer
Posts: 1444
Joined: Fri May 04, 2001 4:00 pm
Are you a spambot?: no
Location: Northern Ontario, Canada
Contact:

Re: Parse DisplayUnit and PixelCrop*

Post by James Heinrich » Wed Nov 28, 2012 3:03 pm

Patch accepted, will be included in v1.9.5.

soulhunter
getID3() v1 developer
Posts: 40
Joined: Mon Jan 11, 2010 5:37 pm
Are you a spambot?: no
Location: Kaliningrad, Russia
Contact:

Re: Parse DisplayUnit and PixelCrop*

Post by soulhunter » Fri Feb 01, 2013 1:13 pm

This patch breaks prior return values and does some incorrect, and unnesessary, calculations on display_x and _y. Calculating display_aspect_ratio is useful, but it should be implemented in all module at the same time, now it is not done. For now it is up to the user to calc this, if nesessary. I've changed matroska module in v1.9.5 to return DispayUnit together with DisplayWidth and DisplayHeight, this will provide all info for display width/height and aspect ratio calculations.

Locked