Page 1 of 1

bug in module.audio-video.quicktime.php

Posted: Mon Nov 03, 2014 8:43 pm
by Evgeny Moysevich
There is a bug in module.audio-video.quicktime.php, it shows itself when memory_limit is disabled ($this->getid3->memory_limit < 0). In this case negative number of bytes is passed to the fread function. I added a check for the $this->getid3->memory_limit in two places in module.audio-video.quicktime.php and now it works for me. I attached modified file, but my IDE reformatted the code, so if you will check the diffs, you will see a lot of them.

Re: bug in module.audio-video.quicktime.php

Posted: Tue Nov 04, 2014 4:51 pm
by James Heinrich
I'm not sure which version you've modified. Could you please, for clarity, supply your patch against the current version of module.audio-video.quicktime.php since there seems to be more differences than what you describe (and not just IDE reformatting).

Re: bug in module.audio-video.quicktime.php

Posted: Wed Nov 05, 2014 4:03 pm
by Evgeny Moysevich
I modified version 1.9.8-20140511. I checked the current version and it seems that issue with memory_limit is already fixed there.

Re: bug in module.audio-video.quicktime.php

Posted: Wed Nov 05, 2014 4:12 pm
by James Heinrich