AAC/MP4 bug/suggestion

[WaldoMonster]

getID3() version: 1.9.14-201703261440
php version: 7.0.18-0ubuntu0.16.04.1 (64-bit)

AAC:

Code: Select all

[audio][dataformat] = aac
[mime_type] = application/octet-stream

Should the mime type be: audio/aac instead of application/octet-stream?



MP4/M4A (with no video):

Code: Select all

[video][dataformat] = quicktime
[video][dataformat][frame_rate] = 43.057996485062
[video][dataformat][resolution_x] = 0
[video][dataformat][resolution_y] = 0
[mimi_type] = audio/mp4

When there is only audio in the container getID3() should not return any [video] key.
Maybe the [video] key can be removed if [mime_type] == audio/mp4?

[James Heinrich]

Thanks for the suggestions.
https://github.com/JamesHeinrich/getID3 ... c5636e941d
https://github.com/JamesHeinrich/getID3 ... 0ce5475ccd

[WaldoMonster]

Thanks for the update!

Both updates seem to work fine for me!
I see you also have updated the monkeys-audio mime_type.