bug in module.audio-video.quicktime.php

Locked
Evgeny Moysevich
User
Posts: 6
Joined: Tue May 26, 2009 2:01 pm
Are you a spambot?: no

bug in module.audio-video.quicktime.php

Post by Evgeny Moysevich » Wed Feb 22, 2012 8:30 am

I'm using getID3 1.9.3-20111213, php version is 5.3.8.
Mime-type of some quicktime mp4 files is incorrectly detected as "audio/mp4" instead of "video/quicktime", also video width and height are missing.
I'm attaching an example of such file, it contains video stream, although it is blank.
I think the bug happens because the video contains 4 track header atoms. Second header contains video width and height, but 3rd and 4th headers are disabled, $atom_structure['flags']['enabled'] != 1. So $info['video']['resolution_x'] and $info['video']['resolution_y'] become unset. I commented code which is run when header is disabled and attached modified module.audio-video.quicktime.php.
Attachments
module.audio-video.quicktime.php
Patched module.audio-video.quicktime.php
(106.26 KiB) Downloaded 725 times
1.mp4
quicktime mp4 file which is detected as an audio file.
(267.75 KiB) Downloaded 3683 times

James Heinrich
getID3() v1 developer
Posts: 1475
Joined: Fri May 04, 2001 4:00 pm
Are you a spambot?: no
Location: Northern Ontario, Canada
Contact:

Re: bug in module.audio-video.quicktime.php

Post by James Heinrich » Fri Sep 14, 2012 7:08 pm

Thanks for the sample file, and I agree with your diagnosis and fix.

Fixed in v1.9.4

Locked